Adjust nnbd spec to allow a const factory in a class with a late final variable #1764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrhn
approved these changes
Jul 28, 2021
…ializer for the error to occur
…to initialize it lazily in a constant object, and we cannot run the code repeatedly
eernstg
force-pushed
the
issue_1763_jul21
branch
from
7c48d0f to
5b34e0d
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf. issue #1763. It looks like we can allow a const factory constructor (which is then necessarily redirecting) in a class that has a late final instance variable.
There will be an implementation effort (it is currently, correctly according to the spec, reported as an error).